In place update to syntax errors, deprecated code, unused variables #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated made to following dimensions/reader.py 1. Updated deprecated code (datafarme.ix --> dataframe.loc) 2. Fix call to datetime64 to reflect python 3 compatible numpy version 3. Commented lines with unused variables 4. Updated correct return variables for quantipy_from_dimensions.
|
This doesn't break any tests, but the dimensions reader part isn't the best tested bit of Quantipy. Do we want to merge this - do we have any testing data for before/after? |
|
Since I submitted this, I have found more things which need to be fixed so do not merge this. Quantipy assumes very simple format of MDD whereas it is never true at least in business I work with. I trying work my way to accommodate more of MDD complexity.
I suggest to close the thread if required.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Geir Freysson <[email protected]>
Sent: Thursday, March 4, 2021 3:02:56 AM
To: Quantipy/quantipy3 <[email protected]>
Cc: Amit Mohite <[email protected]>; Author <[email protected]>
Subject: Re: [Quantipy/quantipy3] In place update to syntax errors, deprecated code, unused variables (#14)
This doesn't break any tests, but the dimensions reader part isn't the best tested bit of Quantipy. Do we want to merge this - do we have any testing data for before/after?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#14 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APFBA3YRVUW2IQZ4LPWU5U3TB2TIRANCNFSM4MLVE4GQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated made to following dimensions/reader.py